the plugin currently has inconsistencies with how lines are indented:
some lines only use tab characters while all other lines use spaces.
Let's make the coding style more uniform by using spaces everywhere.
I apparently forgot to clear out two lines of debugging output from the
script before submitting a pull request.
Those lines of output are super useful for debugging whenever things are
not working as expected (e.g. asterisk has changed its output). So it'll
be more productive to keep them around but only output them if
MUNIN_DEBUG is set.
Since the MeetMe application is not available anymore on Debian, it
makes no sense to keep the graph around. We do however want to keep code
around for parsing stats from MeetMe. So we'll add two "binary" flags
that'll let users which of these two graphs they want.
The default values will favor getting information from ConfBridge which
is the suggested replacement for MeetMe.
An added bonus of this is that some users might decide to disable both
graphs if they use neither applications, which was impossible before.
The MeetMe Asterisk application has been deprecated since Asterisk 1.8.
Debian has also stopped distributing the module with version 11.5.1.
Users now need to migrate to using the ConfBridge application.
Since the application still exists, and some ppl in other Linux distros
probably still use it, we'll keep the code for parsing meetme info for
some time.
This typo causes the following error during munin-update:
asterisk_codecs.graphs_title Asterisk channels per codec' : Parse error in /var/lib/munin/datafile for asterisk_codecs.graphs_title:
This error completely prevents munin-update from creating graphs for the
asterisk plugin.
Asterisk now replies to "Action: command" with the response embedded,
e.g. with "Response: Success" instead of "Response: Follows".
We need to adjust how we parse the server response otherwise we can't
grab any data at all from the AMI.
Closes: #887
The "checkupdates" compound statement (" ... || ... && ...") did not
work due to the equal precendence of both operators (introduced in
6cb5c9e104).
Closes: #1004
Thanks to Ken-ichi Mito for reporting this issue.
