1
0
Fork 0
mirror of https://github.com/munin-monitoring/contrib.git synced 2025-07-21 18:41:03 +00:00
No description
Find a file
Stefan Huehner f0548a37de Fix jstat* plugins to work again with java 6+7, fix PU reporting for
Java8.

jstat column output is not stable across JVM versions (technically
version of jstat binary used).
New columns are added not add the end of column list but in the middle
breaking access via constant index.

Following table shows the known columns per version:
Oracle JDK / OpenJDK 1.5 .. 1.7
   S0C    S1C    S0U    S1U      EC       EU        OC         OU       PC     PU    YGC    YGCT   FGC     FGCT    GCT
Openjdk 1.8 .. 10
   S0C    S1C    S0U    S1U      EC       EU        OC         OU       MC     MU    CCSC   CCSU   YGC     YGCT    FGC    FGCT     GCT
Openjdk 11  .. 12
   S0C    S1C    S0U    S1U      EC       EU        OC         OU       MC     MU    CCSC   CCSU   YGC     YGCT    FGC    FGCT     CGC    CGCT     GCT

Earlier commit here added support for java8+ but using version checking
if version == 1.5 > Use pre-java8 column format, else new format.

As fixing java6+7 would mean more version comparison which is ugly this
cmomit changes retrival logic to the following;
a.) Parse first line jstat output to find position for each label
b.) Then use that position to fetch value from 2nd line

That way code auto-adjusts to any ordering change without needing any
java version specific code or checks.

On the way fix 'Permanent Used' value reporting for java8 which was
broken (missing variable rename from PU -> MU when java8 support was
added).
2018-12-13 15:20:34 +01:00
images
plugins Fix jstat* plugins to work again with java 6+7, fix PU reporting for 2018-12-13 15:20:34 +01:00
samples/munin.conf spelling fixes (2nd try) 2017-04-17 22:43:38 +02:00
t tests: add "shellcheck" tests for "ksh" scripts 2018-03-09 06:10:25 +01:00
templates Resolved issue 884 with munstrap tabid 2018-03-26 19:52:31 +02:00
tools spelling fixes (2nd try) 2017-04-17 22:43:38 +02:00
.flake8 add trivial .flake8 file (for flake8/PEP8) checks 2018-03-27 04:53:05 +02:00
.gitignore gitignore: add '__pycache__' directories 2018-03-09 03:50:39 +01:00
.travis.yml tests: add "shellcheck" tests for "ksh" scripts 2018-03-09 06:10:25 +01:00
README.md move plugin documentation to separate README 2018-03-10 18:18:11 +01:00

This is the repository for all user contributed stuff

contrib/plugins/ - 3rd-party plugins

This is usually where you want to begin your journey.

Here you find a plethora of plugins for the most diverse topics. Please take a look and improve existing or propose new plugins.

Please read the hints for plugin contributions.

See the gallery for a browsable overview of these plugins.

contrib/templates/ - 3rd-party templates

Feel free to update templates here, or even to create new ones.

Bonus points for mobile-friendly ones :)

Note that the one named official is a loose-synced copy of the one in SVN trunk. It should serves as a base for small editions that can be resynced in SVN trunk, so for that :

  • don't copy the whole template
  • directly edit files in this directory

contrib/tools/ - 3rd-party tools

Here, you can put just any kind of tool. Please use this directory instead of a random place on the internet. It makes things way more easy to search for others.

And, it serves as an incubator of SVN trunk/contrib :-)

contrib/samples/ - 3rd-party examples of configs

This serves as a repository for examples of various configs. You know, the ''learn by example'' way of doing things.

Notes to contributors

Commits, Comments & Pull requests

We like to have elementary commits as it is much easier to manage for reviewing and debugging. So please don't be afraid to make as many commits as needed. Merging many commits is as easy as merging one, if not easier.

A good rationale is that each commit shall have a one-liner commit comment as its first line. Ideally that first line has a prefix that shows the part the commit is about. It makes it very easy to see grouped changes, and it enable avoiding to look at the --stat. To know the prefix you should use, you can have a look at already existing commits. Next lines are optional and should only explain the why it is done this particular way.

On the other side, pull requests can regroup many commits at once. Just try to explain in the pull comment the ''why'' we should merge it (if it's not obvious).

Tim Pope wrote a very nice tuto on making good commit comments.

Licenses

All the code here is licensed with the same terms as munin itself (GPLv2), unless specified otherwise inside a file. In all cases the code shall have an OSI-compatible license. Asking for a pull implies that you agree with that fact.

This change was made on Jun 1st 2012. If you wrote some code earlier and you do not agree to the new licensing default, you can :

  • submit a licensing change pull
  • submit a removal pull

Building status

master: Build Status