Previously it returned "yes" and empty graph with all labels having
value "0". Also remove bogus "multigraph redis" line.
TODO: die() in get_conn() makes this plugin to fail if any Redis
instance can't be connected.
docker_ plugin sanitized container names when printing config but
not values which led to a disparity resulting in no data on graphs
for all containers whose names are subject to sanitization. (#1212)
The cgroup data was (yet again) moved to a new location in recent LXC
releases, starting with v3.1.0 from what I could gather.
https://github.com/lxc/lxc/issues/2782 states:
> [The cgroup lxc.payload] exists to adhere to cgroup2 delegation requirements.
Sometimes after reboot munin-async + munin-node runs before knot is
ready. This will result missing knot stats, as there is no static
config in plugin. Cache results and use them instead if knot's output
is empty.
With serials like
Node SN Model Namespace Usage Format FW Rev
---------------- -------------------- ---------------------------------------- --------- -------------------------- ---------------- --------
/dev/nvme0n1 285S100HTYST KXG50ZNV512G TOSHIBA 1 512,11 GB / 512,11 GB 512 B + 0 B AAGA4106
/dev/nvme1n1 S4GENX0N713949 SAMSUNG MZVLB512HBJQ-00000 1 474,89 GB / 512,11 GB 512 B + 0 B EXF7201Q
the internal names (by serial number) were rewritten to
Field Internal name Type Warn Crit Info
/dev/nvme0n1 _85S100HTYST_w derive
/dev/nvme1n1 S4GENX0N713949_w derive
--> the trailing underscore in case of nvme0n1 created problems in graph processing:
[RRD ERROR] Unable to graph /var/cache/munin/www/lxdserver/....agitos.de/nvme_bytes-month.png : undefined vname c285S100HTYST_r
Therefore I added a prefix 'SN_' for internal names.
the line length change doesn't make the world better... without pyflakes I already wondered, why there is an additional linebreak. now it needs two additional one to stay below 99
changes here are tested and work on Python 3.7.3 (debian buster).
in python3 filter returns an object, not an list. I think a list is required here? at least the plugin works as soon as list(...) is added.
need to change from pid to pid.decode, as pid is binary and not a string.
