1
0
Fork 0
mirror of https://github.com/munin-monitoring/contrib.git synced 2025-07-23 06:35:42 +00:00
Commit graph

4430 commits

Author SHA1 Message Date
Lars Kruse
dacb55010a Plugin snmp__synology: fix code style issues reported by flake8 2019-08-14 00:02:40 +02:00
Lars Kruse
8b69c8a1fe Remove plugin solrmulticore
The plugin was introduced in 2011 and superseded by the solr4_ plugin
introduced in 2013.
2019-08-13 23:58:19 +02:00
Lars Kruse
a730d96a1f Remove plugin solr
The plugin saw only one substantial commit (its initial addition to the
repository).  This very first version of the plugin was already broken
(undefined variable "core1") and was never fixed.
Thus it feels sane to assume, that the plugin was never used.
2019-08-13 23:56:27 +02:00
Lars Kruse
be1dfde5da Plugin solr4_: fix code style issues reported by flake8 2019-08-13 23:56:27 +02:00
Lars Kruse
117c508716 Plugin solr4_: format perldoc header 2019-08-13 23:56:26 +02:00
Lars Kruse
a3319a6dc9 Plugin tor_: switch to python3 2019-08-13 23:47:39 +02:00
Lars Kruse
24ab44ca23 Plugin tor_: fix code style issues reported by flake8 2019-08-13 23:47:39 +02:00
Lars Kruse
ebdbf1a92c Plugins weather_*: specify regular expressions as raw strings
New versions of flake8 already complain about the non-raw nature of the
strings (respectively the improper escaping in the regular expression).
2019-08-13 23:03:07 +02:00
Lars Kruse
e5abdeeb12 tests: enable shellcheck for shell-based plugins and flake8 for python-based plugins
Many plugins are still failing these tests.
These expected failures are listed in a file
(t/test-exception-wrapper.expected-failures)
A wrapper script is used for running the tests and comparing the result
with the expectation (based on the file being listed in the above file).

This allows to test all new plugins, while ignoring all known failures.
2019-08-13 05:16:13 +02:00
Lars Kruse
53860136a5 Plugin ejabberd_resources_: fix shellcheck issues 2019-08-13 05:16:13 +02:00
Lars Kruse
94434e4bd8 Plugin zfs-filesystem-graph: fix here-document 2019-08-13 05:16:13 +02:00
Lars Kruse
e68a0308fe Plugin zfs-filesystem-graph: fix autoconf and remove "suggest" 2019-08-13 05:16:13 +02:00
Lars Kruse
be192b5226 Fix multiple python code issues (detected by flake8) 2019-08-13 05:16:13 +02:00
Lars Kruse
7fed3b9765 Fix multiple shellcheck issues 2019-08-13 05:16:13 +02:00
Lars Kruse
5b1099fb83
Merge pull request #1010 from mafri27/master
create icinga plugin to monitor check results
2019-08-12 13:59:27 +02:00
mafri
bc2f7098e2 set execute to icinga_checks 2019-08-12 10:21:21 +02:00
mafri
5633f925bf
create icinga plugin to monitor check results 2019-08-12 09:51:48 +02:00
Lars Kruse
3a4266336c Merge branch 'travis-test'
Fix remaining issues of the test environment.
2019-08-12 06:09:13 +02:00
Lars Kruse
fe379b6f05 Plugin amr: fix regex issue
An unescpaed left brace is rejected by recent versions of perl.
2019-08-12 06:04:02 +02:00
Lars Kruse
9695f9d635 travis: update packages to Ubuntu Bionic 2019-08-12 06:04:02 +02:00
Lars Kruse
64c755a053 travis: add more missing packages 2019-08-12 06:04:02 +02:00
Lars Kruse
a00fb19c8f travis: install requirements via apt 2019-08-12 06:03:56 +02:00
Lars Kruse
6e452ac6dc Plugin lxc: remove fieldname compatibility attempt with double underscores
The attempt of compatibility (introduced in c0fe6dc3c) did not work,
since the previous implementation *replaced* the first character
(if it was invalid - e.g. a digit) instead of prepending an underscore.
2019-08-12 02:36:01 +02:00
Lars Kruse
858f3e3af4 Plugin lxc: rename to "lxc_guests"
The plugin handles details of LXC guests.  Thus we should leave the
remainder of the namespace to other plugins.
2019-08-12 02:36:01 +02:00
Lars Kruse
3ebcb8b550 Plugin lxc: remove reference to framagit repository
Plugins maintained within the contrib repository of munin should not
refer to other locations as their primary source.
(otherwise they should be maintained in that primary source and not in
the contrib repository)
2019-08-12 02:36:01 +02:00
Lars Kruse
2f1be9f908 Plugin lxc: update list of authors 2019-08-12 02:36:01 +02:00
Lars Kruse
f69587c28c Plugin lxc: move to category "virtualization"
See http://guide.munin-monitoring.org/en/latest/reference/graph-category.html#well-known-categories
2019-08-12 02:36:01 +02:00
Lars Kruse
3f8ef105ff Plugin lxc: enable "set -eu" for better error handling
The code should be suitable for "exit-on-error" and "error-on-unset".
2019-08-12 02:36:01 +02:00
Lars Kruse
856572ad9b Plugin lxc: verify the availability of "lxc-ls"
Previously "autoconf" only verified, that /var/lib/lxc exists.  But this
could be just a remainder of a formerly installed lxc package.
2019-08-12 02:36:01 +02:00
Lars Kruse
59cb851cf5 Plugin lxc: add support for MUNIN_CAP_DIRTYCONFIG 2019-08-12 02:36:01 +02:00
Lars Kruse
f00f28cf6f Plugin lxc: use functions for top-level activities
This clarifies the flow of control and allows to use
MUNIN_CAP_DIRTYCONFIG later.
2019-08-12 02:36:01 +02:00
Lars Kruse
4356a024a7 Plugin lxc: clarify name for function "active_guests"
Previously a variable and a function used the same name.
This was no problem, but it can cause confusion.
2019-08-12 02:36:01 +02:00
Lars Kruse
55b881878c Plugin lxc: change the plugin from "bash" to "sh"
No more bashisms were left.
2019-08-12 02:36:01 +02:00
Lars Kruse
6bb4719881 Plugin lxc: separate function for title beautification
This avoids a bashism.
2019-08-12 02:36:01 +02:00
Lars Kruse
8b1d537602 Plugin lxc: simplify interface of "lxc_cgroup" and rename function 2019-08-12 02:36:01 +02:00
Lars Kruse
33b2f3ed8b Plugin lxc: use comprehensible names for variables 2019-08-12 02:36:01 +02:00
Lars Kruse
8b955667c5 Plugin lxc: fix handling of "excludes" parameter
Previously only the first item in the "excludes" environment variable
was really excluded.
2019-08-12 02:36:01 +02:00
Lars Kruse
199b4517cb Plugin lxc: use "grep -E" instead of "egrep" 2019-08-12 02:36:01 +02:00
Lars Kruse
46626b9953 Plugin lxc: simplify implementation of function "active_guests" 2019-08-12 02:36:01 +02:00
Lars Kruse
276e96c0dd Plugin lxc: remove ineffective "sort -u" from function "active_guests"
The output of "lxc-ls" is not line-splitted.  Thus all active guests
are printed in a single line and "sort -u" (removal of non-unique
entries) had no effect.
2019-08-12 02:36:01 +02:00
Lars Kruse
6413375cdc Plugin lxc: simplify processing in function "active_guests" 2019-08-12 02:36:01 +02:00
Lars Kruse
9cdea3c305 Plugin lxc: clarify variable names used in functions 2019-08-12 02:36:01 +02:00
Lars Kruse
da8a74fdcb Plugin lxc: omit output of "max" if the network interface speed is unknown
The "U" value is not defined for the "max" field.
2019-08-12 02:36:01 +02:00
Lars Kruse
914d1c5f25 Plugin lxc: clarify network bandwidth calculation 2019-08-12 02:36:01 +02:00
Lars Kruse
313d195f3b Plugin lxc: simplify interface of "lxc_netdev" 2019-08-12 02:36:01 +02:00
Lars Kruse
89003f0188 Plugin lxc: fix quoting issues 2019-08-12 02:36:01 +02:00
Lars Kruse
0d593014b4 Plugin lxc: fix printing of "${graph_period}"
This specific text token ("${graph_period}") is interpreted by munin and
should not be interpreted by the shell.  Thus it needs to be escaped.
2019-08-12 02:36:01 +02:00
Lars Kruse
e91f7ecba7 Plugin lxc: remove ineffective usage of "bc"
The command "wc -w" already outputs the final result.
Thus we do not need this command (and do not have to depend on it).
2019-08-12 02:36:01 +02:00
Lars Kruse
d415877cdc Plugin lxc: explicitly assign all accepted environment variables 2019-08-12 02:36:01 +02:00
Lars Kruse
ec3a7f4045 Plugin lxc: function "lxc_count_processes" now outputs its result
Previously the result was returned as the exit code of the function
(which would prevent the usage of "set -e").
Additionally the fallback value that was previously calculated outside
of the function is now part of it.
2019-08-12 02:36:01 +02:00