1
0
Fork 0
mirror of https://github.com/munin-monitoring/contrib.git synced 2025-07-21 18:41:03 +00:00
Commit graph

27 commits

Author SHA1 Message Date
Lars Kruse
a7139bcaee Unify shebang for python scripts 2020-10-28 23:38:41 +01:00
Bianco Veigel
6b4a3124c7 switch to python3 2020-09-11 13:15:43 +02:00
Bianco Veigel
2385a6f570 refactoring and python3 compatibility 2020-09-07 19:13:39 +02:00
Bianco Veigel
8cb47cbfbb remove empty line from config 2020-08-30 20:57:50 +02:00
Bianco Veigel
225a9156df add proxmox comment 2020-08-17 02:41:02 +02:00
Bianco Veigel
00f8fce4f8 prevent duplicate graphs and unify line style 2020-08-17 02:41:02 +02:00
Bianco Veigel
113008b06d use name from commandline parameter for kvm 2020-08-17 02:41:02 +02:00
Lars Kruse
8713eb3722 Fix spelling mistakes in comments and descriptions
Thanks, codespell!
2020-03-26 04:23:21 +01:00
Benoît S
c4a08bfa53 libvirt/kvm_*: Simple regex to match VM name
On Debian Stretch the cmdline is something like:
qemu-system-x86_64-enable-kvm-nameguest=vmname,debug-threads=on-S-[…]
Without null characters:
qemu-system-x86_64 -enable-kvm -name guest=vmname,debug-threads=on[…]

We need to match only guest=vmname, so the regex
"^.*guest=([a-zA-Z0-9.-_-]*).*$" is simpler and match the VM name.
The precedent regex "^.*-name\x00([a-zA-Z0-9.-_-]*)\x00\-.*$" was not matching it.

BTW, It seems that \x00 does not match correctly null characters so I removed it.
2019-07-11 22:54:45 +02:00
Lars Kruse
17f784270a Whitespace cleanup
* remove trailing whitespace
* remove empty lines at the end of files
2018-08-02 02:33:25 +02:00
Lars Kruse
33e95e6ff9 Review and unify category assignments of plugins 2018-08-01 23:56:56 +02:00
Lars Kruse
e0b74c69d7 kvm_net: add technical details to 'graph_info' 2018-06-10 22:04:39 +02:00
Lars Kruse
e0df6aa788 kvm_net: improve the network interface name parser and admit its limits
The network interface parser of this plugin was overly specific before.
It relied on a specific format of the arguments handed over to kvm while
starting the VM.  For example the following format was usable:

  ... -netdev tap,ifname=foo,...

But kvm/qemu support a variety of ways for configuring network
interfaces via the commandline.  E.g. libvirt does not use the "ifname"
parameter above.  Thus VMs running on a host controlled via libvirt
cannot be tracked with this plugin.

This limititation is now clearly documented in the header of the plugin.
2018-06-10 22:04:39 +02:00
Lars Kruse
b6c6a02efe kvm_net: update VM name parsing
The old parser seemed to rely on a simple "-name foo" argument format of
kvm/qemu. The changed parser also accepts the following formats:
* name,foo=bar,baz=bot
* guest=name,foo=bar
2018-06-10 22:04:39 +02:00
Lars Kruse
54330cc3e6 kvm_net: simplify argument handling 2018-06-10 22:04:39 +02:00
Lars Kruse
89e4dd6420 kvm_net: avoid shell when using Popen 2018-06-10 22:04:39 +02:00
Lars Kruse
aa8f1a59c4 kvm_net: fix python code style issues 2018-06-10 22:04:39 +02:00
Lars Kruse
a9059703a6 kvm_net: switch to perldoc documentation header 2018-06-10 22:04:39 +02:00
Lars Kruse
3267bbd0ef kvm_net: switch to python3 2018-06-10 22:04:39 +02:00
Lars Kruse
67cc769c87 kvm_net: use print function for python3-compatibility 2018-06-10 22:04:39 +02:00
Lars Kruse
f6080f5f8e kvm_net: unify whitespace 2018-06-10 22:04:39 +02:00
Lars Kruse
7f98e21f2b kvm_net: unify quoting 2018-06-10 17:51:34 +02:00
Lars Kruse
e87d3a6b3c kvm_net: remove unused function 'find_vms_tap' 2018-06-10 17:51:34 +02:00
Jan Egil Vestbø
67d6e559ec Read correct values from /proc/net/dev 2017-09-30 17:44:16 +02:00
Jan Egil Vestbø
621744a6f0 Includes more kvm-processes 2017-09-30 17:42:37 +02:00
Lars Kruse
4b2fcbf8b9 replace hard-coded paths (e.g. '/var/lib/munin/plugin-state') with '$MUNIN_PLUGSTATE'
see http://guide.munin-monitoring.org/en/latest/plugin/env.html
2017-04-18 23:32:55 +02:00
dipohl
f5b816df9e Plugin-Gallery: get better 2nd level headings 2017-02-23 19:53:57 +01:00