1
0
Fork 0
mirror of https://github.com/munin-monitoring/contrib.git synced 2025-07-25 10:28:36 +00:00
Commit graph

56 commits

Author SHA1 Message Date
Lars Kruse
59cb851cf5 Plugin lxc: add support for MUNIN_CAP_DIRTYCONFIG 2019-08-12 02:36:01 +02:00
Lars Kruse
f00f28cf6f Plugin lxc: use functions for top-level activities
This clarifies the flow of control and allows to use
MUNIN_CAP_DIRTYCONFIG later.
2019-08-12 02:36:01 +02:00
Lars Kruse
4356a024a7 Plugin lxc: clarify name for function "active_guests"
Previously a variable and a function used the same name.
This was no problem, but it can cause confusion.
2019-08-12 02:36:01 +02:00
Lars Kruse
55b881878c Plugin lxc: change the plugin from "bash" to "sh"
No more bashisms were left.
2019-08-12 02:36:01 +02:00
Lars Kruse
6bb4719881 Plugin lxc: separate function for title beautification
This avoids a bashism.
2019-08-12 02:36:01 +02:00
Lars Kruse
8b1d537602 Plugin lxc: simplify interface of "lxc_cgroup" and rename function 2019-08-12 02:36:01 +02:00
Lars Kruse
33b2f3ed8b Plugin lxc: use comprehensible names for variables 2019-08-12 02:36:01 +02:00
Lars Kruse
8b955667c5 Plugin lxc: fix handling of "excludes" parameter
Previously only the first item in the "excludes" environment variable
was really excluded.
2019-08-12 02:36:01 +02:00
Lars Kruse
199b4517cb Plugin lxc: use "grep -E" instead of "egrep" 2019-08-12 02:36:01 +02:00
Lars Kruse
46626b9953 Plugin lxc: simplify implementation of function "active_guests" 2019-08-12 02:36:01 +02:00
Lars Kruse
276e96c0dd Plugin lxc: remove ineffective "sort -u" from function "active_guests"
The output of "lxc-ls" is not line-splitted.  Thus all active guests
are printed in a single line and "sort -u" (removal of non-unique
entries) had no effect.
2019-08-12 02:36:01 +02:00
Lars Kruse
6413375cdc Plugin lxc: simplify processing in function "active_guests" 2019-08-12 02:36:01 +02:00
Lars Kruse
9cdea3c305 Plugin lxc: clarify variable names used in functions 2019-08-12 02:36:01 +02:00
Lars Kruse
da8a74fdcb Plugin lxc: omit output of "max" if the network interface speed is unknown
The "U" value is not defined for the "max" field.
2019-08-12 02:36:01 +02:00
Lars Kruse
914d1c5f25 Plugin lxc: clarify network bandwidth calculation 2019-08-12 02:36:01 +02:00
Lars Kruse
313d195f3b Plugin lxc: simplify interface of "lxc_netdev" 2019-08-12 02:36:01 +02:00
Lars Kruse
89003f0188 Plugin lxc: fix quoting issues 2019-08-12 02:36:01 +02:00
Lars Kruse
0d593014b4 Plugin lxc: fix printing of "${graph_period}"
This specific text token ("${graph_period}") is interpreted by munin and
should not be interpreted by the shell.  Thus it needs to be escaped.
2019-08-12 02:36:01 +02:00
Lars Kruse
e91f7ecba7 Plugin lxc: remove ineffective usage of "bc"
The command "wc -w" already outputs the final result.
Thus we do not need this command (and do not have to depend on it).
2019-08-12 02:36:01 +02:00
Lars Kruse
d415877cdc Plugin lxc: explicitly assign all accepted environment variables 2019-08-12 02:36:01 +02:00
Lars Kruse
ec3a7f4045 Plugin lxc: function "lxc_count_processes" now outputs its result
Previously the result was returned as the exit code of the function
(which would prevent the usage of "set -e").
Additionally the fallback value that was previously calculated outside
of the function is now part of it.
2019-08-12 02:36:01 +02:00
Lars Kruse
9af96d2c60 Plugin lxc: draw stacked RAM graphs by default
Previously "ram_display_stacked" defaulted to "false" (non-stacked
graphs).  The new default should be suitable for most situations.
2019-08-12 02:36:01 +02:00
Lars Kruse
ab6f4e3c6e Plugin lxc: fix configurable RAM graphing
Previously (before the multigraph conversion) the configuration setting
for "lxc_ram" was called "areastack".  The multigraph conversion
documented a new configuration setting "ram_areastack", but it was not
used, yet.
Thus we can switch to a more descriptive name: "ram_display_stacked".
2019-08-12 02:36:01 +02:00
Lars Kruse
d004990b21 Plugin lxc: exit after autoconf
Previously processing continued after a successful autoconf operation.
2019-08-12 02:36:01 +02:00
Lars Kruse
6696a4d894 Plugin lxc: unify whitespace 2019-08-12 02:35:57 +02:00
Marc SCHAEFER
c0fe6dc3c7 Compatibility with older field names 2019-08-11 23:09:15 +02:00
Marc SCHAEFER
784b06fe75 Sections and small fix 2019-08-11 23:09:15 +02:00
Marc SCHAEFER
4e321bbc07 First multigraph version 2019-08-11 23:09:15 +02:00
Marc SCHAEFER
ddcc19cd81 Initial version of multigraph version 2019-08-11 23:09:15 +02:00
Marc SCHAEFER
154ffc100b Fix 2019-08-11 23:09:15 +02:00
Marc SCHAEFER
5a3e66beef version 2019-08-11 23:09:15 +02:00
Marc SCHAEFER
50a998b460 areastack option 2019-08-11 23:09:15 +02:00
Marc SCHAEFER
5105020fcf - added systemd possibility for stats - cleanup 2019-08-11 23:09:15 +02:00
Marc SCHAEFER
241b0c6067 Fix for lxc < 3 2019-08-11 23:09:15 +02:00
Marc SCHAEFER
89e0f1c729 Update 2019-08-11 23:09:15 +02:00
Marc SCHAEFER
9ef366c71a - autoconf cleanup - better lxc_clean_fieldname workaround supporting non numeric compatibility - lxc_netdev now compatible with lxc3 and lxc2 at a small CPU cost - lxc_cgroup now compatible with lxc3 and lxc2; may however fail with lxc2 if your config file contains cruft 2019-08-11 23:09:15 +02:00
Marc SCHAEFER
ab67ad805d Comment 2019-08-11 23:09:15 +02:00
Marc SCHAEFER
2cfba9f840 Comment 2019-08-11 23:09:15 +02:00
Marc SCHAEFER
3e865223c2 lxc < 3 support 2019-08-11 23:09:15 +02:00
Marc SCHAEFER
ce6e67fffc lxc: working on buster (gandalf), and almost working on virtual (jessie), except lxc_net 2019-08-11 22:49:48 +02:00
Lars Kruse
17f784270a Whitespace cleanup
* remove trailing whitespace
* remove empty lines at the end of files
2018-08-02 02:33:25 +02:00
Lars Kruse
196c057201 lxc_ram: simplify config with/without 'areastack' 2018-06-10 14:54:15 +02:00
Lars Kruse
a0cafdcf1f lxc_ram: add support for DIRTYCONFIG 2018-06-10 14:50:32 +02:00
Lars Kruse
2ce1b3211a lxc_ram: use functions for actions 2018-06-10 14:49:53 +02:00
Lars Kruse
937ed37dae lxc_ram: unify whitespace 2018-06-10 14:47:00 +02:00
Lars Kruse
a49b362e35 lxc_ram: change from bash to sh 2018-06-10 14:42:10 +02:00
Lars Kruse
aaee069971 lxc_ram: fix shellcheck issues 2018-06-10 14:41:53 +02:00
Lars Kruse
8a5b34c9c8 lxc_ram: simplify quoting 2018-06-10 14:35:12 +02:00
Ken-ichi Mito
1c412d1907 refactor: code of areastack option is hard to understand
- reviewed on https://github.com/munin-monitoring/contrib/pull/738#pullrequestreview-5187474
- split two conditional branches to simple if-else code
2017-03-05 00:48:00 +09:00
Ken-ichi Mito
58e5b2f32c rename option to 'env.areastack' 2017-03-05 00:34:40 +09:00