1
0
Fork 0
mirror of https://github.com/munin-monitoring/contrib.git synced 2025-07-21 18:41:03 +00:00
Commit graph

25 commits

Author SHA1 Message Date
Olivier Mehani
ada3160e9c snmp__if_combined: use instance name in graph titles
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
2022-03-08 21:34:55 +11:00
Olivier Mehani
b14e2347f4 snmp__if_combined: add env.stackedMax to work around sum spikes
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
2022-01-18 22:35:54 +11:00
Olivier Mehani
baf24f9c94 snmp__if_combined: don't set max speed if reported as 0
Some SNMP implementations actively report the interface speed as 0 (e.g., when disconnected). This led the plugin to report both min and max to be 0, which later confuses RRDTool, with errors such as

    [ERROR] Unable to create '/var/lib/munin/example.net/192.2.0.1-snmp_if_combined_vlan-37-send-d.rrd': failed to parse data source 600:0:0: min must be less than max in DS definition

when trying to creates the RRDs. Ultimately, this would prevent the graph creation from suceeding with errors such as

    [ERROR] In RRD: Error updating /var/lib/munin/example.net/192.2.0.1-snmp_if_combined_vlan-37-send-d.rrd: opening '/var/lib/munin/example.net/192.2.0.1-snmp_if_combined_vlan-37-send-d.rrd': No such file or directory

Signed-off-by: Olivier Mehani <shtrom@ssji.net>
2022-01-18 22:35:54 +11:00
Olivier Mehani
4262dc8564 snmp__if_combined: add support for multiple instances
This allows to split the data into smaller groups, e.g., per ifType.

Signed-off-by: Olivier Mehani <shtrom@ssji.net>
2022-01-18 22:35:53 +11:00
Olivier Mehani
ecb1d34814 [snmp__if_combined] Reindent 2021-07-20 11:08:49 +10:00
Olivier Mehani
6ac458ace1 [snmp__if_combined] Add support for stacked series in root graph
From a summary comment in the code:

    If a stacked graph is requested, plot the total. Rather than
    aggregating them with CDEFs of SUMs, we sum them in the script, which
    allows us to create real series than can be easily borrowed by other
    loaning graphs.

Those series are recv_bits and send_bits.

There are longstanding bugs with them (dating back to snmp__if). This
has been documented, as well as some potential ad hoc fixes for the
data.

Some outdated bug were also removed from the doc.

Signed-off-by: Olivier Mehani <shtrom@ssji.net>
2021-07-20 11:08:49 +10:00
Olivier Mehani
61473dfdb0 [snmp__if_combined] fix error value
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
2021-07-20 08:29:11 +10:00
Olivier Mehani
57965df514 [snmp__if_combined] Fix issue with extrainfo
It was not collected / shown in the right spot, resulting in incorrect
information being shown.

Signed-off-by: Olivier Mehani <shtrom@ssji.net>
2021-07-20 08:29:11 +10:00
Olivier Mehani
6bb4a57983 [snmp__if_combined] Fix All interfaces titles so they are better grouped in category views
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
2021-07-20 08:29:11 +10:00
Olivier Mehani
2f2ed4e41a [snmp__if_combined] use snmp v2 description for root traffic graph
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
2021-07-20 08:29:10 +10:00
Lars Kruse
a9c0e2bb59 Unify spelling of author "Dagfinn Ilmari Mannsåker"
Previously some occurrences lacked the special character.
2020-10-19 21:04:03 +02:00
Lars Kruse
8713eb3722 Fix spelling mistakes in comments and descriptions
Thanks, codespell!
2020-03-26 04:23:21 +01:00
klemens
8589c6df43 spelling fixes (2nd try) 2017-04-17 22:43:38 +02:00
Veres Lajos
fba800ae52 typofixes - https://github.com/vlajos/misspell_fixer
Suspicious sections:
plugins/mail/postfix_mail_stats		recieved.label
plugins/nginx/nginx_vhost_traffic
2015-03-02 11:51:38 +00:00
Diego Elio Pettenò
edb8732d8e snmp__if_combined: fix syntax to use explicit 'my'. 2012-11-21 16:19:43 -08:00
Diego Elio Pettenò
7dd40e24d7 snmp__if_combined: output extinfo in the right spot. 2012-11-21 16:19:30 -08:00
Diego Elio Pettenò
bfe824f76a snmp__if_combined: rewrite error handling.
Instead of just having a single "errors" value on the per-interface
error graphs, split it in errors and discards, then provide a total
for the combined graph.

This way it's possible to see more details of what's going on at the
interface level.
2012-11-20 11:50:58 -08:00
Diego Elio Pettenò
36ac271c5d snmp__if_combined: don't use cdef to generate the final value.
This actually simplifies the code, and avoids extra work on the master
side for no reason.
2012-11-20 11:09:59 -08:00
Diego Elio Pettenò
7777738e05 snmp__if_combined: provide CDEFs directives for the combined graph as well.
Borrowed data is raw, so in this case we want to make sure it's expressed in bits rather than octects.
2012-11-20 09:19:17 -08:00
Diego Elio Pettenò
3b62e60756 snmp__if_multi: fix properly ifAlias usage. 2012-11-12 18:58:40 -08:00
Diego Elio Pettenò
a4dbacada0 snmp__if_combined: restore the error graphing as it's done on snmp__if_multi
This brings it basically on feature parity with it, and more.
2012-11-12 18:58:40 -08:00
Diego Elio Pettenò
3505cf5213 snmp__if_combined: graph all interfaces, not only ethernetCsmacd.
For routers it might very well that you're trying to graph tunnels as
well.
2012-11-12 16:43:34 -08:00
Diego Elio Pettenò
5a98a7672f snmp__if_combined: rework to have both combined and split graphs available.
This basically almost replaces snmp__if_multi in full, as sub-graphs
with interface traffic are generated as a set of detailed graphs. It
doesn't yet compose graphs with the interface errors though.
2012-11-12 16:37:21 -08:00
Diego Elio Pettenò
5cad9514bd snmp__if_combined: don't pull in unneeded data. 2012-08-28 14:19:50 -07:00
Diego Elio Pettenò
c0e85a7cfa snmp__if_combined: create a single graph showing traffic from all interfaces.
This allows normalising the graph range and shows aberrations in the
bandwidth usage more clearly.
2012-08-09 13:47:14 -07:00