From cdb9a4456f915e8ebd5c5eab689932af88e2469b Mon Sep 17 00:00:00 2001
From: Lars Kruse <devel@sumpfralle.de>
Date: Thu, 26 Mar 2020 02:57:40 +0100
Subject: [PATCH] Plugin xfs_frag: fix shellcheck issues

---
 plugins/disk/xfs_frag                      | 29 +++++++++++-----------
 t/test-exception-wrapper.expected-failures |  1 -
 2 files changed, 14 insertions(+), 16 deletions(-)

diff --git a/plugins/disk/xfs_frag b/plugins/disk/xfs_frag
index d41d4fcc..cb3d9843 100755
--- a/plugins/disk/xfs_frag
+++ b/plugins/disk/xfs_frag
@@ -32,7 +32,7 @@ Paul Saunders L<darac+munin@darac.org.uk>
 
 =cut
 
-declare -a ARRY
+declare -a TOKENS
 shopt -s nocasematch
 
 case $1 in
@@ -42,12 +42,12 @@ graph_title XFS fragmentation
 graph_vlabel Percent
 graph_category disk
 EOF
-		cat /etc/mtab | awk '{print $2 " " $3}' | while read LINE
-		do
-			ARRY=($LINE)
-			if [[ ${ARRY[1]} =~ xfs ]]; then
-				FIELDNAME=$(echo ${ARRY[0]} | sed 's/^[^A-Za-z_]/_/; s/[^A-Za-z0-9_]/_/g')
-				echo "$FIELDNAME.label ${ARRY[0]}"
+		awk '{print $2 " " $3}' </etc/mtab | while read -r LINE; do
+			# shellcheck disable=SC2206
+			TOKENS=($LINE)
+			if [[ ${TOKENS[1]} =~ xfs ]]; then
+				FIELDNAME=$(echo "${TOKENS[0]}" | sed 's/^[^A-Za-z_]/_/; s/[^A-Za-z0-9_]/_/g')
+				echo "$FIELDNAME.label ${TOKENS[0]}"
 				echo "$FIELDNAME.type GAUGE"
 			fi
 		done
@@ -55,13 +55,12 @@ EOF
 		;;
 esac
 
-cat /etc/mtab | awk '{print $2 " " $3 " " $1}' | while read LINE
-do
-	ARRY=($LINE)
-	if [[ ${ARRY[1]} =~ xfs ]]; then
-		FIELDNAME=$(echo ${ARRY[0]} | sed 's/^[^A-Za-z_]/_/; s/[^A-Za-z0-9_]/_/g')
-		FRAG=$(xfs_db -c frag -r ${ARRY[2]} | sed 's/.*fragmentation factor \(.*\)%.*/\1/')
-		echo $FIELDNAME.value $FRAG
+awk '{print $2 " " $3 " " $1}' </etc/mtab | while read -r LINE; do
+	# shellcheck disable=SC2206
+	TOKENS=($LINE)
+	if [[ ${TOKENS[1]} =~ xfs ]]; then
+		FIELDNAME=$(echo "${TOKENS[0]}" | sed 's/^[^A-Za-z_]/_/; s/[^A-Za-z0-9_]/_/g')
+		FRAG=$(xfs_db -c frag -r "${TOKENS[2]}" | sed 's/.*fragmentation factor \(.*\)%.*/\1/')
+		echo "$FIELDNAME.value $FRAG"
 	fi
 done
-
diff --git a/t/test-exception-wrapper.expected-failures b/t/test-exception-wrapper.expected-failures
index 91a67d93..9f1e7b68 100644
--- a/t/test-exception-wrapper.expected-failures
+++ b/t/test-exception-wrapper.expected-failures
@@ -85,7 +85,6 @@ plugins/disk/raid-mismatch-count
 plugins/disk/scsi_queue
 plugins/disk/snmp__areca_
 plugins/disk/useddisk
-plugins/disk/xfs_frag
 plugins/dkim/dkimproxy_mails
 plugins/dovecot/dovecot
 plugins/dovecot/dovecot_stats_