Mirrors/Munin-Contrib
1
0
Fork 0
mirror of https://github.com/munin-monitoring/contrib.git synced 2025-07-21 18:41:03 +00:00
Code Issues Releases Wiki Activity

unify DIRTYCONFIG handling in shell and python plugins

Browse source 
The following issues were fixed:
* comparison too broad (e.g. "0" misinterpreted as "true")
* python: comparing string with number (is never equal in python)
* unwanted non-zero exitcode (compound command "&&" as last command in
  shell code block (e.g. "case" or "if" branch))
* access to unset variable (shell style issue)
This commit is contained in:
Lars Kruse 2018-04-07 02:11:05 +02:00
parent 270be2f59e
commit c81c20ab3b
22 changed files with 32 additions and 48 deletions
Download patch file Download diff file Expand all files Collapse all files

8
plugins/bind/bind9_server_stats
View file

@ -69,11 +69,9 @@ if [ "$1" = "config" ]; then
echo ${key}.type COUNTER
done
# If dirty config capability is enabled then fall through
# to output the data with the config information.
if [ "$MUNIN_CAP_DIRTYCONFIG" = "" ]; then
exit 0
fi
# If dirty config capability is enabled then fall through
# to output the data with the config information.
if [ "${MUNIN_CAP_DIRTYCONFIG:-0}" != "1" ]; then exit 0; fi
fi
# Output the stats.