Mirrors/Munin-Contrib
1
0
Fork 0
mirror of https://github.com/munin-monitoring/contrib.git synced 2025-07-23 06:35:42 +00:00
Code Issues Releases Wiki Activity

refactor code

Browse source 
Added common functions autoconf_check_readable and fail.
Added some TODOs for later completion.
Updated messages from upstream plugins.
This commit is contained in:
Helmut Grohne 2013-02-05 12:38:12 +01:00
parent e71641b88f
commit bb7bf0bcd7
15 changed files with 97 additions and 166 deletions
Download patch file Download diff file Expand all files Collapse all files

17
tools/munin-plugins-busybox/fw_packets.c
View file

@ -25,17 +25,11 @@ int fw_packets(int argc, char **argv) {
"forwarded.min 0");
return 0;
}
if(!strcmp(argv[1], "autoconf")) {
if(0 == access(PROC_NET_SNMP, R_OK))
return writeyes();
else
return writeno(PROC_NET_SNMP " not readable");
}
}
if(!(f=fopen(PROC_NET_SNMP, "r"))) {
fputs("cannot open " PROC_NET_SNMP "\n", stderr);
return 1;
if(!strcmp(argv[1], "autoconf"))
return autoconf_check_readable(PROC_NET_SNMP);
}
if(!(f=fopen(PROC_NET_SNMP, "r")))
return fail("cannot open " PROC_NET_SNMP);
while(fgets(buff, 1024, f)) {
if(!strncmp(buff, "Ip: ", 4) && isdigit(buff[4])) {
fclose(f);
@ -57,6 +51,5 @@ int fw_packets(int argc, char **argv) {
}
}
fclose(f);
fputs("no ip line found in " PROC_NET_SNMP "\n", stderr);
return 1;
return fail("no ip line found in " PROC_NET_SNMP);
}