Mirrors/Munin-Contrib
1
0
Fork 0
mirror of https://github.com/munin-monitoring/contrib.git synced 2025-07-21 18:41:03 +00:00
Code Issues Releases Wiki Activity

Plugin proftpd_bytes: fix shellcheck issues

Browse source
This commit is contained in:
Lars Kruse 2018-08-02 00:09:36 +02:00
parent e62a8e3142
commit b925a10155
1 changed files with 24 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

50
plugins/ftp/proftpd_bytes
View file

@ -14,50 +14,48 @@
#%# family=auto #%# family=auto
#%# capabilities=autoconf #%# capabilities=autoconf
MAXLABEL=20
mktempfile () { mktempfile () {
mktemp -t $1 mktemp -t "$1"
} }
LOGFILE=${logfile:-/var/log/proftpd/xferlog} LOGFILE=${logfile:-/var/log/proftpd/xferlog}
LOGTAIL=${logtail:-`which logtail`} LOGTAIL=${logtail:-$(which logtail)}
STATEFILE=$MUNIN_PLUGSTATE/xferlog-bytes.offset STATEFILE=$MUNIN_PLUGSTATE/xferlog-bytes.offset
if [ "$1" = "autoconf" ]; then if [ "$1" = "autoconf" ]; then
if [ -f "${LOGFILE}" -a -n "${LOGTAIL}" -a -x "${LOGTAIL}" ] ; then if [ -f "$LOGFILE" ] && [ -n "$LOGTAIL" ] && [ -x "$LOGTAIL" ] ; then
echo yes echo yes
else else
echo "no (missing logfile or 'logtail' executable)" echo "no (missing logfile or 'logtail' executable)"
fi fi
exit 0 exit 0
fi fi
if [ "$1" = "config" ]; then if [ "$1" = "config" ]; then
echo 'graph_title FTP Server Bytes' echo 'graph_title FTP Server Bytes'
echo 'graph_args --base 1000 -l 0' echo 'graph_args --base 1000 -l 0'
echo 'graph_vlabel FTP Server Bytes' echo 'graph_vlabel FTP Server Bytes'
echo 'graph_category network' echo 'graph_category network'
echo 'ftp_get.label Bytes GET' echo 'ftp_get.label Bytes GET'
echo 'ftp_put.label Bytes PUT' echo 'ftp_put.label Bytes PUT'
exit 0 exit 0
fi fi
ftp_get=U ftp_get=U
ftp_put=U ftp_put=U
TEMP_FILE=`mktempfile munin-xferlog-bytes.XXXXXX` TEMP_FILE=$(mktempfile munin-xferlog-bytes.XXXXXX)
if [ -n "$TEMP_FILE" -a -f "$TEMP_FILE" ] if [ -n "$TEMP_FILE" ] && [ -f "$TEMP_FILE" ]
then then
$LOGTAIL ${LOGFILE} $STATEFILE | grep "[[:space:]][oi][[:space:]]" > ${TEMP_FILE} "$LOGTAIL" "$LOGFILE" "$STATEFILE" | grep "[[:space:]][oi][[:space:]]" >"$TEMP_FILE"
ftp_get=`grep "[[:space:]]o[[:space:]]" ${TEMP_FILE} | awk '{s += $8} END { if ( s ) print s ; else print "0" }'` ftp_get=$(grep "[[:space:]]o[[:space:]]" "$TEMP_FILE" | awk '{s += $8} END { if ( s ) print s ; else print "0" }')
ftp_put=`grep "[[:space:]]i[[:space:]]" ${TEMP_FILE} | awk '{s += $8} END { if ( s ) print s ; else print "0" }'` ftp_put=$(grep "[[:space:]]i[[:space:]]" "$TEMP_FILE" | awk '{s += $8} END { if ( s ) print s ; else print "0" }')
/bin/rm -f $TEMP_FILE /bin/rm -f "$TEMP_FILE"
fi fi
echo "ftp_get.value ${ftp_get}" echo "ftp_get.value $ftp_get"
echo "ftp_put.value ${ftp_put}" echo "ftp_put.value $ftp_put"