diff --git a/t/todo.org b/t/todo.org index 6b58f16b..b2ace3e7 100644 --- a/t/todo.org +++ b/t/todo.org @@ -2,22 +2,19 @@ Summary: - Failed 7/1006 subtests + Failed 5/1006 subtests - (less 1 skipped subtest: 998 okay) + (less 1 skipped subtest: 1000 okay) +** [0/1] Failing test +*** TODO Failed test 'plugins/snmp/snmp__brocade_ifs: python compile' -** [0/1] Need to investigate - -*** TODO not ok 572 - plugins/network/d-link-dir-655-router-statistics-plugin: ruby syntax check - - Need to investigate. + python plugin with error in regular expression string. #+BEGIN_EXAMPLE -# Failed test 'plugins/network/d-link-dir-655-router-statistics-plugin: ruby syntax check' -# at t/test.t line 169. +# at t/test.t line 162. # -# Command: ruby -cw d-link-dir-655-router-statistics-plugin +# Command: python -m py_compile snmp__brocade_ifs # # STDOUT: # @@ -25,12 +22,12 @@ # # STDERR: # -# /home/travis/.rvm/rubies/ruby-1.9.3-p547/lib/ruby/site_ruby/1.9.1/rubygems/core_ext/kernel_require.rb:54:in `require': cannot load such file -- auto_gem (LoadError) -# from /home/travis/.rvm/rubies/ruby-1.9.3-p547/lib/ruby/site_ruby/1.9.1/rubygems/core_ext/kernel_require.rb:54:in `require' +# SyntaxError: ('invalid syntax', ('snmp__brocade_ifs', 272, 22, "regex_str = '^snmp_'(.+)'_brocade_ifs'\n")) # # #+END_EXAMPLE + ** [0/4] False positives *** TODO not ok 110 - plugins/system/solaris-memstat: ksh syntax check @@ -114,35 +111,6 @@ not ok 319 - plugins/rabbitmq/rabbitmq_connections # at t/test.t line 64. #+END_EXAMPLE -*** TODO not ok 538 - plugins/network/ldap_connections - - False positive in checkbashisms at 'ESTABLISHED$"'. - - Still, quite horrible shell code. - -#+BEGIN_EXAMPLE -# Subtest: plugins/network/ldap_connections -1..2 -ok 1 - sh syntax check -not ok 2 - checkbashisms -# Failed test 'checkbashisms' -# at t/test.t line 169. -# -# Command: checkbashisms ldap_connections -# -# STDOUT: -# -# -# -# STDERR: -# -# possible bashism in ldap_connections line 130 ($"foo" should be eval_gettext "foo"): -# echo "$(echo $ip | sed 's/\./_/g')_${port}.value $(grep "^tcp[46]\{0,1\}\([[:space:]]\{1,\}[[:digit:]]\{1,\}\)\{2\}[[:space:]]\{1,\}$ip[\.:]$port[[:space:]].*ESTABLISHED$" $TEMP_FILE | wc -l | sed 's/[[:space:]]*//g')" -# -# -# Looks like you failed 1 test of 2. -#+END_EXAMPLE - ** [0/1] Blame the CI provider @@ -168,4 +136,3 @@ not ok 2 - checkbashisms # # #+END_EXAMPLE -