1
0
Fork 0
mirror of https://github.com/munin-monitoring/contrib.git synced 2025-07-22 02:51:03 +00:00

Plugin snmp__juniper_spu: migrate to Python3

This commit is contained in:
Lars Kruse 2020-11-26 02:08:55 +01:00
parent e7e8ff9916
commit 8152186b9a
2 changed files with 128 additions and 120 deletions

View file

@ -1,22 +1,4 @@
#!/usr/bin/env python
# -*- coding: utf-8 -*-
# Copyright (C) 2014 Johann Schmitz <johann@j-schmitz.net>
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU Library General Public License as published by
# the Free Software Foundation; version 2 only
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU Library General Public License for more details.
#
# You should have received a copy of the GNU Library General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
#
#!/usr/bin/env python3
"""
=head1 NAME
@ -27,11 +9,6 @@ snmp__juniper_spu - Network monitoring plugin for the SPU's in Juniper firewalls
Make sure your Juniper device is accessible via SNMP (e.g. via snmpwalk) and the munin-node
has been configured correctly.
=head1 MAGIC MARKERS
#%# family=snmpauto
#%# capabilities=snmpconf
=head1 VERSION
0.0.1
@ -42,11 +19,31 @@ Open a ticket at https://github.com/ercpe/contrib if you find one.
=head1 AUTHOR
Johann Schmitz <johann@j-schmitz.net>
Copyright (C) 2014 Johann Schmitz <johann@j-schmitz.net>
=head1 LICENSE
GPLv2
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU Library General Public License as published by
the Free Software Foundation; version 2 only
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU Library General Public License for more details.
You should have received a copy of the GNU Library General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
SPDX-License-Identifier: GPL-2.0-only
=head1 MAGIC MARKERS
#%# family=snmpauto
#%# capabilities=snmpconf
=cut
"""
@ -68,14 +65,14 @@ if debug:
logging.basicConfig(level=logging.DEBUG, format='%(asctime)s %(levelname)-7s %(message)s')
try:
match = re.search("^(?:|.*\/)snmp_([^_]+)_juniper_spu$", sys.argv[0])
match = re.search(r"^(?:|.*/)snmp_([^_]+)_juniper_spu$", sys.argv[0])
host = match.group(1)
request = match.group(2)
match = re.search("^([^:]+):(\d+)$", host)
match = re.search(r"^([^:]+):(\d+)$", host)
if match is not None:
host = match.group(1)
port = match.group(2)
except:
except Exception:
pass
jnxJsSPUMonitoringObjectsTable = '1.3.6.1.4.1.2636.3.39.1.12.1.1'
@ -95,6 +92,7 @@ jnxJsSPUMonitoringFlowSessIPv6 = jnxJsSPUMonitoringObjectsTable + '.1.13'
jnxJsSPUMonitoringCPSessIPv4 = jnxJsSPUMonitoringObjectsTable + '.1.14'
jnxJsSPUMonitoringCPSessIPv6 = jnxJsSPUMonitoringObjectsTable + '.1.15'
class JunOSSnmpClient(object):
def __init__(self, host, port, community):
@ -109,10 +107,12 @@ class JunOSSnmpClient(object):
self.transport,
0, 10,
jnxJsSPUMonitoringObjectsTable)
# ignoreNonIncreasingOids=True) # only available with pysnmp >= 4.2.4 (?) and broken anyway
# the line below is only available with pysnmp >= 4.2.4 (?) and broken anyway
# ignoreNonIncreasingOids=True)
if errorIndication:
logging.error("SNMP bulkCmd for devices failed: %s, %s, %s" % (errorIndication, errorStatus, errorIndex))
logging.error("SNMP bulkCmd for devices failed: %s, %s, %s"
% (errorIndication, errorStatus, errorIndex))
return {}
devices = {}
@ -140,28 +140,32 @@ class JunOSSnmpClient(object):
devices, data = self.get_data()
data_def = [
('flow', self.hostname, 'Flow sessions', '--base 1000', '# of sessions', jnxJsSPUMonitoringMaxFlowSession),
('cp', self.hostname, 'Central point sessions', '--base 1000', '# of sessions', jnxJsSPUMonitoringMaxCPSession),
('flow', self.hostname, 'Flow sessions', '--base 1000', '# of sessions',
jnxJsSPUMonitoringMaxFlowSession),
('cp', self.hostname, 'Central point sessions', '--base 1000', '# of sessions',
jnxJsSPUMonitoringMaxCPSession),
]
for datarow, hostname, title, args, vlabel, max_prefix in data_def:
print """multigraph juniper_{datarow}
print("""multigraph juniper_{datarow}
host_name {hostname}
graph_title {title}
graph_vlabel {vlabel}
graph_args {args}
graph_category network
graph_info {title}""".format(datarow=datarow, hostname=hostname, title=title, args=args, vlabel=vlabel)
graph_info {title}""".format(datarow=datarow, hostname=hostname, title=title, args=args,
vlabel=vlabel))
for suffix, node in devices.iteritems():
for suffix, node in devices.items():
ident = "%s_%s" % (datarow, node)
print """{label}.info {title} on {node}
print("""{label}.info {title} on {node}
{label}.label {node}
{label}.type GAUGE
{label}.max {max}""".format(title=title, label=ident, node=node, max=data.get(max_prefix + suffix))
{label}.max {max}""".format(title=title, label=ident, node=node,
max=data.get(max_prefix + suffix)))
for suffix, node in devices.iteritems():
print """
for suffix, node in devices.items():
print("""
multigraph juniper_{datarow}.{node}
host_name {hostname}
graph_title {title} on {node}
@ -186,41 +190,46 @@ graph_info {title}
{datarow}Max.label Max
{datarow}Max.draw LINE0
{datarow}Max.type GAUGE
""".format(datarow=datarow, hostname=hostname, title=title, args=args, vlabel=vlabel, node=node)
""".format(datarow=datarow, hostname=hostname, title=title, args=args, vlabel=vlabel, node=node))
def execute(self):
devices, data = self.get_data()
print("multigraph juniper_flow")
for suffix, node in devices.items():
print("flow_%s.value %s"
% (node, data.get(jnxJsSPUMonitoringCurrentFlowSession + suffix, 0)))
print "multigraph juniper_flow"
for suffix, node in devices.iteritems():
print "flow_%s.value %s" % (node, data.get(jnxJsSPUMonitoringCurrentFlowSession + suffix, 0))
for suffix, node in devices.items():
print("multigraph juniper_flow.%s" % node)
print("flowV4.value %s" % data.get(jnxJsSPUMonitoringFlowSessIPv4 + suffix, 0))
print("flowV6.value %s" % data.get(jnxJsSPUMonitoringFlowSessIPv6 + suffix, 0))
print("flowCurrent.value %s"
% data.get(jnxJsSPUMonitoringCurrentFlowSession + suffix, 0))
print("flowMax.value %s" % data.get(jnxJsSPUMonitoringMaxFlowSession + suffix, 0))
for suffix, node in devices.iteritems():
print "multigraph juniper_flow.%s" % node
print "flowV4.value %s" % data.get(jnxJsSPUMonitoringFlowSessIPv4 + suffix, 0)
print "flowV6.value %s" % data.get(jnxJsSPUMonitoringFlowSessIPv6 + suffix, 0)
print "flowCurrent.value %s" % data.get(jnxJsSPUMonitoringCurrentFlowSession + suffix, 0)
print "flowMax.value %s" % data.get(jnxJsSPUMonitoringMaxFlowSession + suffix, 0)
print("multigraph juniper_cp")
for suffix, node in devices.items():
print("cp_%s.value %s"
% (node, data.get(jnxJsSPUMonitoringCurrentCPSession + suffix, 0)))
print "multigraph juniper_cp"
for suffix, node in devices.iteritems():
print "cp_%s.value %s" % (node, data.get(jnxJsSPUMonitoringCurrentCPSession + suffix, 0))
for suffix, node in devices.items():
print("multigraph juniper_cp.%s" % node)
print("cpV4.value %s" % data.get(jnxJsSPUMonitoringCPSessIPv4 + suffix, 0))
print("cpV6.value %s" % data.get(jnxJsSPUMonitoringCPSessIPv6 + suffix, 0))
print("cpCurrent.value %s" % data.get(jnxJsSPUMonitoringCurrentCPSession + suffix, 0))
print("cpMax.value %s" % data.get(jnxJsSPUMonitoringMaxCPSession + suffix, 0))
for suffix, node in devices.iteritems():
print "multigraph juniper_cp.%s" % node
print "cpV4.value %s" % data.get(jnxJsSPUMonitoringCPSessIPv4 + suffix, 0)
print "cpV6.value %s" % data.get(jnxJsSPUMonitoringCPSessIPv6 + suffix, 0)
print "cpCurrent.value %s" % data.get(jnxJsSPUMonitoringCurrentCPSession + suffix, 0)
print "cpMax.value %s" % data.get(jnxJsSPUMonitoringMaxCPSession + suffix, 0)
c = JunOSSnmpClient(host, port, community)
if "snmpconf" in sys.argv[1:]:
print "require %s" % (jnxJsSPUMonitoringObjectsTable, )
print("require %s" % (jnxJsSPUMonitoringObjectsTable, ))
sys.exit(0)
else:
if not (host and port and community):
print "# Bad configuration. Cannot run with Host=%s, port=%s and community=%s" % (host, port, community)
print("# Bad configuration. Cannot run with Host=%s, port=%s and community=%s"
% (host, port, community), file=sys.stderr)
sys.exit(1)
if "config" in sys.argv[1:]:

View file

@ -401,7 +401,6 @@ plugins/router/dsl-stats
plugins/router/freeboxuptime
plugins/router/motorola_sb6141
plugins/router/snmp__juniper
plugins/router/snmp__juniper_spu
plugins/router/snmp__linksys_poe
plugins/router/speedport_300
plugins/rsync/rsyncd_bytes