Ruby plugins: apply code changes as suggested by "rubocop --auto-correct"

plugins/mssql/microsoft-sql

@@ -21,34 +21,32 @@ You should have received a copy of the GNU General Public License along
 with this program; if not, write to the Free Software Foundation, Inc.,
 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
-
 Prerequistes:
-	1) /etc/odbc.ini and /etc/freetds.conf
-	2) rubygems
-	3) ruby-dbi
+  1) /etc/odbc.ini and /etc/freetds.conf
+  2) rubygems
+  3) ruby-dbi
 
 Usage:
-	1) copy this script to the munin install plugins directory (e.g. /usr/share/munin/plugins)
-	2) chmod to allow executable to others
-	3) create symbolic link in /etc/munin/plugins
+  1) copy this script to the munin install plugins directory (e.g. /usr/share/munin/plugins)
+  2) chmod to allow executable to others
+  3) create symbolic link in /etc/munin/plugins
           ln -s /usr/share/munin/plugins/mssql_transaction.rb /etc/munin/plugins/mssql_transaction.rb
 
 Parameters:
-	autoconf
-	config (required)
+  autoconf
+  config (required)
 
 Config variables:
-	sqluser : mssql user who has view server state privilege
-	sqlpass : password for the mssql user
-	dsn     : datasource name as defined in /etc/odbc.ini
-	instance: instance to monitor
+  sqluser : mssql user who has view server state privilege
+  sqlpass : password for the mssql user
+  dsn     : datasource name as defined in /etc/odbc.ini
+  instance: instance to monitor
 
 #%# family=auto
 #%# capabilities=autoconf
 
 =end
 
-
 require 'rubygems'
 require 'dbi'
 
@@ -74,7 +72,7 @@ transaction_query = "select cntr_value from sys.dm_os_performance_counters
                      and object_name = 'SQLServer:Databases'
                      and instance_name = ?"
 
-all_instance_names = Array.new
+all_instance_names = []
 sth = dbh.execute(instance_name_query)
 sth.fetch do |row|
   all_instance_names.push(row[0].strip)
@@ -84,25 +82,26 @@ sth.finish
 #
 # autoconf
 #
-if ARGV[0] == "autoconf"
+case ARGV[0]
+when 'autoconf'
   if all_instance_names.length > 1 && sqluser.length > 1 && sqlpass.length > 1
-    puts "yes"
+    puts 'yes'
   else
-    puts "no"
+    puts 'no'
     puts "Usage: #{__FILE__} autoconf|conf"
   end
   exit 0
 #
 # config definition
 #
-elsif ARGV[0] == "config"
-  puts "graph_args --base 1000 -r --lower-limit 0"
-  puts "graph_title MSSQL Transactions/s"
-  puts "graph_category db"
-  puts "graph_info This graph shows transactions/s"
-  puts "graph_vlabel transactions/s"
-  puts "graph_scale no"
-  puts "graph_period second"
+when 'config'
+  puts 'graph_args --base 1000 -r --lower-limit 0'
+  puts 'graph_title MSSQL Transactions/s'
+  puts 'graph_category db'
+  puts 'graph_info This graph shows transactions/s'
+  puts 'graph_vlabel transactions/s'
+  puts 'graph_scale no'
+  puts 'graph_period second'
 
   all_instance_names.sort.each do |s|
     puts "#{s}.label #{s}"
@@ -122,7 +121,7 @@ all_instance_names.sort.each do |k|
   sth.execute(k)
   sth.fetch do |row|
     # since type is DERIVE, need to convert value to integer then to string
-    puts "#{k.to_s}.value #{row[0].to_i.to_s}"
+    puts "#{k}.value #{row[0].to_i}"
   end
 end
 sth.finish