From 285c11cdfb1ca8cd1068a2499005e31fd7d3ef30 Mon Sep 17 00:00:00 2001
From: iborodikhin <iborodikhin@gmail.com>
Date: Thu, 8 Nov 2012 09:06:45 +0600
Subject: [PATCH] Fixed undefined variable use and division by zero in redis
 plugin

---
 plugins/redis/redis_ | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/plugins/redis/redis_ b/plugins/redis/redis_
index 4277b536..d71e1671 100755
--- a/plugins/redis/redis_
+++ b/plugins/redis/redis_
@@ -76,7 +76,9 @@ read($sock, $rep, substr($result,1)) || die "can't read from socket: $!";
 my $hash;
 foreach (split(/\r\n/, $rep)) {
     my ($key,$val) = split(/:/, $_, 2);
-    $hash->{$key} = $val;
+    if (defined($key)) {
+        $hash->{$key} = $val;
+    }
 }
 close ($sock);
 
@@ -136,8 +138,14 @@ switch ($0) {
         }
             
         my $total = $hash->{'keyspace_hits'} + $hash->{'keyspace_misses'};
-        printf("hitratio.value %.2f\n", $hash->{'keyspace_hits'} / $total * 100);
-        printf("missratio.value %.2f\n", $hash->{'keyspace_misses'} / $total * 100);
+        my $hitratio = 0;
+        my $missratio = 0;
+        if ($total > 0) {
+            $hitratio = $hash->{'keyspace_hits'} / $total * 100;
+            $missratio = $hash->{'keyspace_misses'} / $total * 100;
+        }
+        printf("hitratio.value %.2f\n", $hitratio);
+        printf("missratio.value %.2f\n", $missratio);
     }