Mirrors/Munin-Contrib
1
0
Fork 0
mirror of https://github.com/munin-monitoring/contrib.git synced 2025-07-25 18:38:30 +00:00
Code Issues Releases Wiki Activity

refactor: code of areastack option is hard to understand

Browse source 
- reviewed on https://github.com/munin-monitoring/contrib/pull/738#pullrequestreview-5187474
- split two conditional branches to simple if-else code
This commit is contained in:
Ken-ichi Mito 2017-03-05 00:19:58 +09:00
parent 58e5b2f32c
commit 1c412d1907
1 changed files with 19 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

28
plugins/lxc/lxc_ram
View file

@ -78,16 +78,10 @@ if [ "$1" = "config" ]; then
echo 'mem_usage_'$guest'.type GAUGE' echo 'mem_usage_'$guest'.type GAUGE'
echo 'mem_usage_'$guest'.draw AREASTACK' echo 'mem_usage_'$guest'.draw AREASTACK'
done done
fi
for guest_name in $guest_names; do
guest="$(clean_fieldname $guest_name)"
for guest_name in $guest_names;
do
guest="$(clean_fieldname $guest_name)"
if [ "$areastack" != "true" ]; then
echo 'mem_usage_'$guest'.label '$guest_name': Mem usage'
echo 'mem_usage_'$guest'.type GAUGE'
fi
echo 'mem_cache_'$guest'.label '$guest_name': Cache' echo 'mem_cache_'$guest'.label '$guest_name': Cache'
echo 'mem_cache_'$guest'.type GAUGE' echo 'mem_cache_'$guest'.type GAUGE'
echo 'mem_active_'$guest'.label '$guest_name': Active' echo 'mem_active_'$guest'.label '$guest_name': Active'
@ -96,6 +90,22 @@ if [ "$1" = "config" ]; then
echo 'mem_inactive_'$guest'.type GAUGE' echo 'mem_inactive_'$guest'.type GAUGE'
done done
else
for guest_name in $guest_names;
do
guest="$(clean_fieldname $guest_name)"
echo 'mem_usage_'$guest'.label '$guest_name': Mem usage'
echo 'mem_usage_'$guest'.type GAUGE'
echo 'mem_cache_'$guest'.label '$guest_name': Cache'
echo 'mem_cache_'$guest'.type GAUGE'
echo 'mem_active_'$guest'.label '$guest_name': Active'
echo 'mem_active_'$guest'.type GAUGE'
echo 'mem_inactive_'$guest'.label '$guest_name': Inactive'
echo 'mem_inactive_'$guest'.type GAUGE'
done
fi
exit 0 exit 0
fi fi