From 0d6b938c7b6b06e7be71ee3d8a1fca3f2f5e858c Mon Sep 17 00:00:00 2001
From: pcy <pcy@ulyssis.org>
Date: Wed, 15 Jul 2020 02:34:17 +0200
Subject: [PATCH] [plugins/systemd/systemd_units] Optionally hide extinfo of
 active services

These services are running fine, so the extinfo would mostly just clutter
the webui while making the extinfo of relevant (i.e. down) services
harder to find.
---
 plugins/systemd/systemd_units | 20 +++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

diff --git a/plugins/systemd/systemd_units b/plugins/systemd/systemd_units
index 47f43541..e65bf9e0 100755
--- a/plugins/systemd/systemd_units
+++ b/plugins/systemd/systemd_units
@@ -31,6 +31,8 @@ C<grep -E>):
 
 An example configuration might be something like this:
 
+=over 2
+
  [systemd_units]
  env.failed_warning 0
  env.failed_critical 5
@@ -38,10 +40,15 @@ An example configuration might be something like this:
  env.inactive_critical 20
  env.exclude boring
  env.inactive_exclude sleepy
+ env.silence_active_extinfo 1
+
+=back
 
 In the example above, we've overridden the default warning and critical levels for failed units, added warning
 and critical levels for inactive units, then filtered out boring units from all results and filtered out sleepy
-units from results for the inactive state.
+units from results for the inactive state. In addition to that, only more extensive info of non-active units
+are displayed in order to quickly see which units are failing and why in the webui. (By default, all extra info
+about all units is displayed.)
 
 =head1 AUTHOR
 
@@ -63,6 +70,7 @@ GPLv2
 
 failed_warning="${failed_warning:-0}"
 failed_critical="${failed_critical:-10}"
+silence_active_extinfo="${silence_active_extinfo:-0}"
 
 states="active \
 	reloading \
@@ -123,8 +131,14 @@ fetch () {
 		count=$(echo "$state_unit_list" | grep -c "$state$")
 		echo "$state.value $count"
 		extinfo=$(echo "$state_unit_list" | grep "$state$" | cut -d " " -f 1 | tr '\n' ' ')
-		if [ -n "$extinfo" ]; then
-			echo "$state.extinfo" "$extinfo"
+		if [ "$silence_active_extinfo" = "0" ]; then
+			if [ -n "$extinfo" ]; then
+				echo "$state.extinfo" "$extinfo"
+			fi
+		else
+			if [ -n "$extinfo" ] && [ "$state" != "active" ]; then
+				echo "$state.extinfo" "$extinfo"
+			fi
 		fi
 	done
 }